feat(si-pkg,object-tree): add optional kind key to SiPkg #2709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29b9139 to
c4f0a98
Compare
c4f0a98 to
9e07294
Compare
|
bors try |
Adds a new key to the root node of an SiPkg that expresses the "kind" of a package (currently `SiPkgKind::Module` and `SiPkgKind::WorkspaceBackup`). The "kind" key is optional, and packages without (like the existing modules), default to `SiPkgKind::Module`. To support this, a new reader function was added to `object-tree` to support reading a key that may or may not be in the expected position (`read_key_line_value_opt`).
9e07294 to
ffa08b3
Compare
tryBuild failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new key to the root node of an SiPkg that expresses the "kind" of a package (currently
SiPkgKind::ModuleandSiPkgKind::WorkspaceBackup). The "kind" key is optional, and packages without (like the existing modules), default toSiPkgKind::Module. To support this, a new reader function was added toobject-treeto support reading a key that may or may not be in the expected position (read_key_line_value_opt).