8000 Space inserted when using variable for output name · Issue #91 · szaghi/FoBiS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Space inserted when using variable for output name #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmacmackin opened this issue Dec 19, 2016 · 4 comments
Closed

Space inserted when using variable for output name #91

cmacmackin opened this issue Dec 19, 2016 · 4 comments
Assignees
@szaghi

Comments

@cmacmackin
Copy link
Contributor

I found that when I use a variable to store the name of the output in a fobos file, a space gets inserted between the output directory and the variable contents. This makes it seem like these are separate arguments to the compiler and leads to an error. For example, a fobos file like:

[common-variables]
$STATIC_LIB = libstatic.a

[static-lib]
compiler = gnu
mklib = static
target = file.f90
build_dir = ./build
output = $STATIC_LIB

will result in the following archive command being run:

ar -rcs build/ libstatic.a  build/obj/file.o
@szaghi
Copy link
Owner
szaghi commented Dec 19, 2016

@cmacmackin

Great! Got it, I'll fix today, new release is coming.

@szaghi szaghi self-assigned this Dec 19, 2016
@szaghi szaghi added the bug label Dec 19, 2016
szaghi added a commit that referenced this issue Dec 19, 2016
@szaghi
Bugfix #91, dangerous white space fobos global vars
268481d 
Bugfix issue-#91, dangerous white space fobos global vars

Why:

Chris found a very dangerous bug: *spurious* white spaces were added
around global variables defined into fobos file.

This change addresses the need by:

Sanitize global variables substitution.

Side effects:

Add build test 23.
szaghi referenced this issue Dec 19, 2016
@szaghi
Merge branch 'hotfix/bugfix-#91-dangerous_white_spaces_for_fobos_glob…
a10383e 
…al_variables'
@szaghi
Copy link
Owner
szaghi commented Dec 19, 2016

@cmacmackin

Dear Chris, in the just uploaded master branch I should have fixed this bug.

I added also a specific test this one.

Soon, I'll create a new release with the other features.

I leave this open until your check on the new release.

szaghi added a commit that referenced this issue Dec 19, 2016
@szaghi
Merge tag 'vbugfix-#91-dangerous_white_spaces_for_fobos_global_variab…
a58baac 
…les' into develop

Bugfix #91, stable release, fully backward compatible.
@cmacmackin
Copy link
Contributor Author

Great, thanks.

@szaghi
Copy link
Owner
szaghi commented Dec 22, 2016

Should be fixed, feel free to reopen if not.

@szaghi szaghi closed this as completed Dec 22, 2016
@szaghi szaghi removed the bug label Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szaghi szaghi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szaghi @cmacmackin
0