8000 set MVTX_APPLYMISALIGNMENT to true by pinkenburg · Pull Request #1099 · sPHENIX-Collaboration/macros · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

set MVTX_APPLYMISALIGNMENT to true #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set MVTX_APPLYMISALIGNMENT to true #1099

wants to merge 1 commit into from

Conversation

pinkenburg
Copy link
Contributor

Finally make this the new default

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 3f9b54bb2f22fde2ceb5a21cf202b6205c920bb4. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@osbornjd
Copy link
Contributor

I don't object to the point of this PR, but just to comment this is likely to wreak havoc on the QA. I started a build to see what the effect is

@osbornjd
Copy link
Contributor 8000

Good thing we ran the CI... a couple notes from the log file https://web.sdcc.bnl.gov/jenkins-sphenix/job/sPHENIX/job/test-tracking-low-occupancy-qa/7112/console

  1. The alignment isn't actually loaded. I'm guessing the proper file isn't in the simulated CDB tag, it is loaded from https://github.com/sPHENIX-Collaboration/coresoftware/blob/f61adf1d092dddbc7b87e853e2b2c092ae33f5eb/offline/packages/trackreco/MakeActsGeometry.cc#L1046
  2. There is a mismatch between the Acts geometry and the g4 geometry for some reason. I'm looking into why

@osbornjd
Copy link
Contributor

Actually on second thought, there might be a mismatch because the alignment isn't properly loaded into G4 from the CDB but Acts thinks that there should be... So fixing the CDB tag might solve both issues

@osbornjd
Copy link
Contributor
osbornjd commented Apr 29, 2025 •
edited
Loading

This still dies for the same reason (albeit a new hitsetkey is identified), although the log indicates that the misaligned geometry is now correctly being loaded. So now something else is apparently going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinkenburg @osbornjd
0