Bug/629 show selected value #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2018 21:22
remove left border on input, adjust padding
|
How do multi-selects react to the change? It might all be a non-issue now that we have the new layout mechanism, but at one point the I'm going to pull the code and run the dev page locally, to play around a bit too. |
stevenharman
reviewed
Sep 6, 2018
|
@sagalbot can we get this fix out in a |
jeanvier
added a commit
to 3xw/vue-select
that referenced
this pull request
Sep 14, 2018
This reverts commit 3024f13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the input displays the currently selected value of single selects while dropdown is open. @stevenharman this PR removes the
hiddenclass. I did a bunch of testing, it looks like we just don't need it. Any red flags?hiddenclass &inputClassespropertyBefore
After
Closes #629
Related #621