multiple mode - add/remove actions to support vuex strictmode #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eriknygren thank you for this fix :) |
babcfe8 to
3e3fb18
Compare
What --- - In multiple mode: Update adding or removing a value to use spread operator or filter, instead of mutating the array directly. Why --- So vuex strict mode doesn't throw warnings.
3e3fb18 to
ec2c725
Compare
|
@renaudaste no worries! No news I'm afraid for now. It depends on whenever @sagalbot is around to review/merge. |
|
any news about merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
spread operator or filter, instead of mutating the array directly.
This makes it play nicely with
:value="value" @input="onChange"patternWhy
So vuex strict mode doesn't throw warnings.
#529