8000 update planaritry to 4.0.0.0 by dimpase · Pull Request #40153 · sagemath/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update planaritry to 4.0.0.0 #40153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

update planaritry to 4.0.0.0 #40153

wants to merge 3 commits into from

Conversation

dimpase
Copy link
Member
@dimpase dimpase commented May 23, 2025

long overdue - also, supports gcc-15 out of the box

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase dimpase requested a review from antonio-rojas May 23, 2025 17:39
@dimpase dimpase requested a review from enriqueartal May 23, 2025 17:41
@dimpase dimpase mentioned this pull request May 23, 2025
Open
2 tasks
@enriqueartal
Copy link
Contributor

It works in Fedora 42, and the gnu17 option is no more needed now.

@orlitzky
Copy link
Contributor

You'll also n 8000 eed the Gentoo patch for dev-gap/digraphs

@enriqueartal
Copy link
Contributor

And this fedora patch for semigroups would help for gap_packages.

@gmou3
Copy link
Contributor
gmou3 commented May 24, 2025

works on Arch, thanks!

@antonio-rojas
Copy link
Contributor
antonio-rojas commented May 26, 2025 •
edited
Loading

The spkg-configure test doesn't work because it searches for a no longer existing header. Using planarity/graph.h, as sagelib itself does, should work (I haven't tested, I'm fully switched to meson now).

@dimpase
Copy link
Member Author
dimpase commented May 26, 2025

@antonio-rojas this should fix the regression you pointed out. Hopefully upstream has settled on the header naming scheme.

@dimpase
Copy link
Member Author
dimpase commented May 27, 2025

You'll also need the Gentoo patch for dev-gap/digraphs

I gather it's https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-gap/digraphs/files/digraphs-planarity-4.x.patch
which has to be applied to the GAP tarball (after changes in the file location)

@dimpase
Copy link
Member Author
dimpase commented Jun 1, 2025

@antonio-rojas - could you review it?

@antonio-rojas
Copy link
Contributor

Builds on Arch and uses system planarity

dimpase added 3 commits June 2, 2025 07:18
@dimpase
update planaritry
36816ac 
long overdue - also, supports gcc-15 out of the box
@dimpase
take care of deprecation of graph.h in 4.0
9e59a3e 
removed compile checks, as they were testing for a very old
planarity version, and keeping it needs figuring out the header
version to use.
@dimpase
GAP pkg digraphs patch from gentoo
9c31736
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 2, 2025

Documentation preview for this PR (built with commit 9c31736; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmou3 gmou3 gmou3 approved these changes

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

@enriqueartal enriqueartal Awaiting requested review from enriqueartal

Assignees
No one assigned
Labels
c: packages: standard s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimpase @enriqueartal @orlitzky @gmou3 @antonio-rojas
0