8000 Add get_parse and get_parse_or generic over return T getters by lweberk · Pull Request #27 · sagiegurari/envmnt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add get_parse and get_parse_or generic over return T getters #27

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

lweberk
Copy link
@lweberk lweberk commented Mar 3, 2021

Closes #26

@sagiegurari
Copy link
Owner

@lweberk this is really great. can you also add tests please?
would love to see tests for various format types + errors.

@lweberk
Copy link
Author
lweberk commented Mar 4, 2021

Sure thing. Just let me figure out the codecov pipeline/machinery. I'm a little bewildered by it. It is showing things as new (numeric.rs, bulk.rs, ...) that are not. Not showing things it should (generic.rs) and showing things it should not (error.rs)

@sagiegurari
Copy link
Owner

i don't care about coverage, just basic tests. so lets have generic_test.rs for that like in other modules.

@lweberk
Copy link
Author
lweberk commented Mar 4, 2021

Perhaps some docs under usage as well?

8000

@sagiegurari
Copy link
Owner

that would help. thanks

@lweberk
Copy link
Author
lweberk commented Mar 4, 2021

Ok, there we go

@sagiegurari
Copy link
Owner

looks great. going to merge this in.
i'll probably update some examples and do minor cosmetic stuff..... there is another api i'm going to add (unreleated) and i'll release a new version.
thanks a lot!!!

@sagiegurari sagiegurari changed the base branch from master to 0.8.5 March 4, 2021 17:06
@sagiegurari sagiegurari merged commit 2bbfb7b into sagiegurari:0.8.5 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get and parse to a generic T inferred from return T
2 participants
0