Add Safe v1.5.0 Deployments #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (rather large) PR adds the Safe v1.5.0 deployments. Unfortunately, this PR is much larger than one would expect because of testing - there used to be pre-baked `src/__tests__/assets/v1` folder that were used for `toMatchObject` assertions, and would require re-generating them for v1.5.0. Instead, I refactored the tests to check slightly fewer properties, but we should still have similar coverage and make the tests easier to maintain going forward (without the need for an additional `assets` folder). One additional change, was to rename `DefaultCallbackHandler` to `TokenCallbackHandler`, the new name starting Safe v1.3.0+, which makes sense as the contract is intended for providing token callback implementations. The `getDefaultCallbackHandlerDeployment*` functions were left in as aliases for backwards compatibility.
remedcu
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (rather large) PR adds the Safe v1.5.0 deployments. Unfortunately, this PR is much larger than one would expect because of testing - there used to be pre-baked
src/__tests__/assets/v1folder that were used fortoMatchObjectassertions, and would require re-generating them for v1.5.0.Instead, I refactored the tests to check slightly fewer properties, but we should still have similar coverage and make the tests easier to maintain going forward (without the need for an additional
assetsfolder).One additional change, was to rename
DefaultCallbackHandlertoTokenCallbackHandler, the new name starting Safe v1.3.0+, which makes sense as the contract is intended for providing token callback implementations. ThegetDefaultCallbackHandlerDeployment*functions were left in as aliases for backwards compatibility.