fix(cloudflare): add preview IDs for KV, D1, and R2 in wrangler.json #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle preview IDs in Wrangler JSON for `wrangler dev --remote` compatibility: - Add preview_id field for KV namespaces that replicates the main namespace ID - Add preview_bucket_name field for R2 buckets that replicates the main bucket name - Add preview_database_id field for D1 databases that replicates the main database ID This fixes issues where KV, D1, and R2 throw errors in `wrangler dev --remote` when preview IDs are not provided in the wrangler.json file. Since Alchemy doesn't use environments in the typical Wrangler way, we replicate the main IDs as preview IDs to ensure compatibility. Fixes #411 Co-authored-by: sam <sam-goodwin@users.noreply.github.com>
|
@claude add a test in wrangler.json.test.ts |
|
Claude finished @sam-goodwin's task —— View job Adding test for wrangler.json preview IDs ✅I've successfully added comprehensive test coverage for the preview ID functionality in wrangler.json.ts. Todo List:
Added 4 new test cases:
Summary: The tests ensure that preview IDs are properly replicated from main IDs, providing the compatibility needed for |
commit: |
Add comprehensive test coverage for the preview ID functionality in wrangler.json generation: - KV namespace test: verifies preview_id matches main namespace ID - D1 database test: verifies preview_database_id matches main database ID - R2 bucket test: verifies preview_bucket_name matches main bucket name - Mixed bindings test: verifies all three types work correctly together These tests ensure the preview IDs are properly set for `wrangler dev --remote` compatibility. Co-authored-by: sam <sam-goodwin@users.noreply.github.com>
🧹 Website Preview Cleaned UpThe website preview for this PR has been cleaned up as the PR was closed. 🤖 Preview resources have been removed from Cloudflare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
Handle preview IDs in Wrangler JSON for
wrangler dev --remotecompatibility:This fixes issues where KV, D1, and R2 throw errors in
wrangler dev --remotewhen preview IDs are not provided in the wrangler.json file.Since Alchemy doesn’t use environments in the typical Wrangler way, we replicate the main IDs as preview IDs to ensure compatibility.
Generated with Claude Code