Update template names to avoid bun namespace collisions #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
🧹 Website Preview Cleaned UpThe website preview for this PR has been cleaned up as the PR was closed. 🤖 Preview resources have been removed from Cloudflare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this wild issue where typescript wasn't resolving. It persisted even after clearing
node_modules. After listing outnode_modulesI noticed this❯ ls -al node_modules/ ... lrwxrwxrwx@ - just-be 27 Jun 00:43 typescript -> ../alchemy/templates/typescript ...Turns out some of the names in templates are generic enough to conflict with dependency names and bun just symlinks those packages over the original dependencies.