feat: allow binding individual secrets #393
Conversation
commit: |
| const updateErrorMessage = | ||
| updateErrorData.errors?.[0]?.message || updateResponse.statusText; | ||
| throw new Error( | ||
| `Error updating secret '${secretName}': ${updateErrorMessage}`, | ||
| ); | ||
| } | ||
| } else { | ||
| // Some other error occurred during creation | ||
| const createErrorMessage = | ||
| createErrorData.errors?.[0]?.message || createResponse.statusText; | ||
| throw new Error( | ||
| `Error creating secret '${secretName}': ${createErrorMessage}`, | ||
| ); |
There was a problem hiding this comment.
Call handleApiError instead of doing this manually each time.
🧹 Website Preview Cleaned UpThe website preview for this PR has been cleaned up as the PR was closed. 🤖 Preview resources have been removed from Cloudflare. |
|
@claude please open another PR that deletes secrets-store.test.ts and re-writes secret.test.ts to adopt the default secrets store with delete: false (instead of creating them because cloudflare only allows one per account). Just test binding a single secret resource and return it in the worker response to test end to end. Keep it simple. |
|
Claude finished @sam-goodwin's task —— View job • Creating follow-up PR for secrets testingWorking on sam's request to create a new PR that simplifies the secrets testing approach. Todo List:
SummarySuccessfully created a simplified secrets test approach:
The test now uses the account's default secrets store instead of creating new ones, which aligns with Cloudflare's limitation of one secrets store per account. |
No description provided.