-
Notifications
You must be signed in to change notification settings - Fork 8
[ruby] Update Ruby 3.3.8 → 3.4.3 #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@depfu refresh |
b8c634f
to
0dfcb41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2335 +/- ##
===========================================
- Coverage 81.27% 81.25% -0.02%
===========================================
Files 481 481
Lines 18543 18551 +8
Branches 278 278
===========================================
+ Hits 15071 15074 +3
- Misses 3470 3475 +5
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fixes 👌
This pull request includes updates to dependencies, syntax improvements, and minor feature additions. The most important changes involve upgrading the Ruby version, adding a new gem, and updating method syntax for improved readability and consistency.
Dependency Updates:
.ruby-version
: Updated Ruby version from3.3.8
to3.4.3
.Dockerfile
: Updated the base Ruby image from3.3.8-slim
to3.4.3-slim
.Gemfile
: Added thesyslog
gem to the default group.Syntax Improvements:
app/helpers/page_helper.rb
: Updated method definitions (page
,card
) to use the shorthand block parameter (&
) instead of explicitly naming the block. This change simplifies the code and aligns it with modern Ruby conventions. [1] [2]Minor Feature Additions:
spec/spec_helper.rb
: Addedsyslog/logger
to the test setup, likely to support logging in test environments.Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.What changed?
Release Notes
3.4.3
3.4.2
3.4.1
3.4.0
All Depfu comment commands