8000 Set severity and options at the top of function by bquorning · Pull Request #436 · sasstools/sass-lint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set severity and options at the top of function #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2015
Merged

Set severity and options at the top of function #436

merged 1 commit into from
Dec 21, 2015

Conversation

bquorning
Copy link
Contributor

Checking typeof fullRule 1 time up front instead of 3-4 times throughout the function seems cleaner.

DCO 1.1 Signed-off-by: Benjamin Quorning dco@quorning.net

@bquorning bquorning force-pushed the set-severity-and-options-variables branch from 97b43ef to 8c0b3b4 Compare December 2, 2015 15:48
@DanPurdy
Copy link
Member
DanPurdy commented Dec 7, 2015

Hi @bquorning Is there an issue open for this? We usually only accept PR's based on issues so that everyone can agree on the right way forward.

I'll leave this one for @Snugug to have a look

@bquorning
Copy link
Contributor Author

No, there is no open issue. I was just reading through the source and found this part a bit hard to understand.

@bquorning bquorning force-pushed the set-severity-and-options-variables branch from 8c0b3b4 to 70c6edd Compare December 8, 2015 10:13
@benthemonkey
Copy link
Member

This code seems much more readable to me, so I'm in favor of it. 👍

@DanPurdy
Copy link
Member
DanPurdy com 8000 mented Dec 21, 2015

I'm ok with this once it's updated to the latest develop. Thanks!

@bquorning
🎨 Set severity and options at top of function
7b5c0ee 
Checking `typeof fullRule` 1 time up front instead of 3-4 times
throughout the function seems cleaner.
@bquorning bquorning force-pushed the set-severity-and-options-variables branch from 70c6edd to 7b5c0ee Compare December 21, 2015 09:57
@bquorning
Copy link
Contributor Author

Rebased on origin/develop.

@DanPurdy DanPurdy added this to the 1.5.0 milestone Dec 21, 2015
@DanPurdy DanPurdy removed the on hold label Dec 21, 2015
@DanPurdy
Copy link
Member

Thanks @bquorning

DanPurdy added a commit that referenced this pull request Dec 21, 2015
@DanPurdy
Merge pull request #436 from bquorning/set-severity-and-options-varia…
ca32ff3 
…bles

Set severity and options at the top of function
@DanPurdy DanPurdy merged commit ca32ff3 into sasstools:develop Dec 21, 2015
@bquorning bquorning deleted the set-severity-and-options-variables branch December 21, 2015 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bquorning @DanPurdy @benthemonkey
0