Fix error with pseudo-element rule and move lists to data assets #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| path = require('path'); | ||
|
|
||
| var pseudoElements = yaml.safeLoad( | ||
| fs.readFileSync(path.join(__dirname, '../../data', 'pseudoElements.yml'), 'utf8') |
There was a problem hiding this comment.
Do we really need these in separate files right now? They're not being used anywhere else and with such small datasets it seems unnecessary to force two expensive synchronous file read operations on users.
There was a problem hiding this comment.
I think they fit the bill. They're both data lists that are likely to change over time and it makes sense to have them in the data/ directory instead of in the rule.
Having just run a quick console.time on it, they only take around ~0.1ms to 0.2ms each so I don't personally feel it's too expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug where the rule tries to use
charAtwithout first checking that it is a string.Closes #670 and moves lists of pseudo classes and elements to data assets.
DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com