8000 Fix issue with indentation and import at-rule and maps by DanPurdy · Pull Request #814 · sasstools/sass-lint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issue with indentation and import at-rule and maps #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2016

Conversation

DanPurdy
Copy link
Member
@DanPurdy DanPurdy commented Aug 6, 2016

Fixes an issue with the indentation rule where an at-rule (@import) wasn't correctly being exited from and thus threw all maps directly below it off.

Actually fixes an issue where at rules that didn't contain blocks were incorrectly identified and caused issues with anything following them.

fixes #779
fixes #783

<DCO 1.1 Signed-off-by: Dan Purdy dan@danpurdy.co.uk>

@DanPurdy DanPurdy changed the title Fix issue with import at-rule and maps Fix issue with indentation and import at-rule and maps Aug 6, 2016
@coveralls
Copy link
coveralls commented Aug 8, 2016

Coverage Status

Coverage increased (+0.003%) to 97.376% when pulling d04c1e1 on DanPurdy:feature/fix-indentation-imports into ddae351 on sasstools:develop.

@coveralls
Copy link
coveralls commented Aug 8, 2016

Coverage Status

Coverage increased (+0.003%) to 97.376% when pulling d04c1e1 on DanPurdy:feature/fix-indentation-imports into ddae351 on sasstools:develop.

@DanPurdy DanPurdy force-pushed the feature/fix-indentation-imports branch from d04c1e1 to c32d9b7 Compare August 8, 2016 20:52
@coveralls
Copy link
coveralls commented Aug 8, 2016

Coverage Status

Coverage remained the same at 97.275% when pulling c32d9b7 on DanPurdy:feature/fix-indentation-imports into d439a88 on sasstools:develop.

@DanPurdy DanPurdy force-pushed the feature/fix-indentation-imports branch from c32d9b7 to 056fec8 Compare August 8, 2016 20:55
@coveralls
Copy link
coveralls commented Aug 8, 2016

Coverage Status

Coverage remained the same at 97.275% when pulling 056fec8 on DanPurdy:feature/fix-indentation-imports into d439a88 on sasstools:develop.

@DanPurdy DanPurdy added this to the 1.9.0 milestone Aug 8, 2016
@bgriffith bgriffith merged commit dc5230c into sasstools:develop Aug 10, 2016
@bgriffith bgriffith deleted the feature/fix-indentation-imports branch August 10, 2016 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested maps whitespacing does not lint correctly @import throws off indent rule starting with v1.8.0
3 participants
0