fix: imv preview compatibility with filenames containing spaces or long paths #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the improvements. Although I think it’s a bug in imv that it can’t handle filenames with spaces, and should be fixed there. Also, in the hacks section the snippets provide a minimal and easy to understand way of implementing new features, which are supposed to be customised as per user needs. For a more sophisticated implementation, I’d publish a plugin and list it in the plugins section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the existing
Image viewer (imv)hack to handle paths containing spaces or long filenames that breakimv-msg.Instead of passing the path directly, the Bash script now:
/tmpimv-msg/tmpcleanTested on: