8000 Add Proxy-Authorization header if proxy_url has username by ngicks · Pull Request #185 · sbstp/attohttpc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Proxy-Authorization header if proxy_url has username #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2025
Merged

Add Proxy-Authorization header if proxy_url has username #185

merged 2 commits into from
Mar 2, 2025

Conversation

ngicks
Copy link
Contributor
@ngicks ngicks commented Feb 27, 2025

quick fix for #184

@ngicks ngicks mentioned this pull request Feb 27, 2025
Open
@ngicks ngicks marked this pull request as ready for review February 28, 2025 01:03
@ngicks
Copy link
Contributor Author
ngicks commented Feb 28, 2025

Tested with this build https://github.com/ngicks/volta/tree/feat-support-proxy-authorization
under my company's proxy, it is working.

If anything else is needed I would be happy to do that.

@sbstp
Copy link
Owner
sbstp commented Mar 1, 2025

Thanks for the catch, this seems like a pretty big issue. I would probably enable this feature all the time, even if the basic-auth feature is not enabled, to avoid surprising behavior.

@ngicks ngicks force-pushed the feat-add-proxy-authorization branch from 160650e to feeb0c0 Compare March 2, 2025 04:19
@ngicks
Copy link
Contributor Author
ngicks commented Mar 2, 2025 •
edited
Loading

Force-pushed fixing casing (basicAuth -> basic_auth) to keep commit history clean, I see MRs are merged without squash.
Changed base64 to be non-optional. Proxy-Authorization header is always added if proxy_url has authorization info.

@sbstp sbstp merged commit 5cd04cc into sbstp:master Mar 2, 2025
4 checks passed
@sbstp
Copy link
Owner
sbstp commented Mar 2, 2025

Yeah I use rebase merges when people take the time to make nice commits, squash otherwise.

@sbstp
Copy link
Owner
sbstp commented Mar 2, 2025

Thanks

@ngicks ngicks deleted the feat-add-proxy-authorization branch March 2, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngicks @sbstp
0