Remove npm depends #662
Merged
Remove npm depends #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure why I didn't do this before. But having looked at the AUR for arch created by @dadosch, and then done subsequent research, it's obvious the node_modules should be built at package time. This *completely* removes any need for npm at all and therefore means we can support nodejs 10 again. This also closes #422. It does make the package bigger, but I'll sweep that up in a later commit. This commit also fixes up a couple of variables.
Closed
sbs20
added a commit
that referenced
this pull request
Oct 25, 2023
This commit just follows on from #662. Now it's not required it can also be removed from system info and various other installs e.g. in docker
Merged
sbs20
added a commit
that referenced
this pull request
Oct 25, 2023
This commit just follows on from #662. Now it's not required it can also be removed from system info and various other installs e.g. in docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure why I didn't do this before. But having looked at the AUR for arch created by @dadosch, and then done subsequent research, it's obvious the node_modules should be built at package time.
This completely removes any need for npm at all and therefore means we can support nodejs 10 again.
This also closes #422.
It does make the package bigger, but I'll sweep that up in a later commit.
This commit also fixes up a couple of variables.