Add transfer / send unit test. Use Node7 #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 6 6
Lines 370 370
Branches 84 84
=======================================
Hits 361 361
Misses 9 9Continue to review full report at Codecov.
|
|
Have now:
Believe this works and should fix the bug. I've also E2E validated the testrpc-sc changes by running this branch against our Zeppelin fork here. Unless anyone has improvements to suggest, will probably merge and publish this tomorrow. |
area
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test to validate a fix in
ethereumjs-vm-scfor the transfer / send bug discovered in #106.Test is skipped because it will fail pending the vm change.@area I wrote this using await/async and I've bumped the
circle.ymlandeslintup to Node 7. If this is troubling (irritating?) - let me know. I'll revert without complaint. 🙂It's nice for our tests but we probably shouldn't use any V7 features in the tool itself until truffle and/or testrpc make the same move.
Requesting a review from you re: node.