8000 Feedback for PR-112 by hotzenklotz · Pull Request #114 · scalableminds/chatroom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 14, 2021. It is now read-only.

Feedback for PR-112 #114

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Feedback for PR-112 #114

merged 1 commit into from
Jul 30, 2019

Conversation

hotzenklotz
Copy link
Member
@hotzenklotz hotzenklotz commented Jul 29, 2019 •
edited
Loading

Applied the feedback from PR #112.

Rasa message including text AND image || buttons | | attachments should now be supported correctly. E.g. in config.yml

utter_thanks:
  -text: "Thank"
   image: "someUrl"
   buttons: 
       - title: "mybutton"
         payload: "payload"

Most changes are auto-genterated by prettier / formatting.

@CLAassistant
Copy link
CLAassistant commented Jul 29, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hotzenklotz hotzenklotz requested a review from jstriebel July 29, 2019 12:36
@hotzenklotz hotzenklotz self-assigned this Jul 29, 2019
@hotzenklotz hotzenklotz added the enhancement New feature or request label Jul 29, 2019
@nicholasbulka
Copy link
Contributor

nice, thank you for fixing my PR and for this code in the first place!

jstriebel
jstriebel approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor
@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but code LGTM

@hotzenklotz hotzenklotz merged commit 1192037 into master Jul 30, 2019
@hotzenklotz hotzenklotz deleted the pr112-feedback branch July 30, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jstriebel jstriebel jstriebel approved these changes

Assignees

@hotzenklotz hotzenklotz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hotzenklotz @CLAassistant @nicholasbulka @jstriebel
0