8000 feat: sql highlighting by Mensh1kov · Pull Request #7467 · scalameta/metals · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: sql highlighting #7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: sql highlighting #7467

wants to merge 1 commit into from

Conversation

Mensh1kov
Copy link

Now, in Scala code, when using the fr and sql interpolators, SQL syntax highlighting is automatically applied:
sql-highlighting-demo

tgodzik
tgodzik approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like a pretty clear implementation, great work!

@tgodzik
Copy link
Contributor
tgodzik commented May 20, 2025

Ach, but now I see that some tests are failing, would you be able to take a look at them?

@tgodzik tgodzik self-requested a review May 20, 2025 14:37
@dos65
Copy link
Member
dos65 commented May 20, 2025

@tgodzik yep, we will fix them soon

feat: sql highlighting
b2b4388 
Now, in Scala code, when using the `fr` and `sql` interpolators, SQL syntax highlighting is automatically applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik Awaiting requested review from tgodzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mensh1kov @tgodzik @dos65
0