improvement: save mcp port #7485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I would be better to save this in some json file inside |
|
@kasiaMarek Not having an sqlite dependency would definitely make it easier to wrap some existing mcp-proxy tool, yes. That said, an ideal future solution would just use metals CLI itself as the mcp-proxy – so it will have access to sqlite, making this a bit easier. |
tgodzik
reviewed
May 19, 2025
|
I think that's fine, the bigger limitation comes from how clients actually launch servers (from root, not from workspace), but Metals can't really solve this. |
tgodzik
approved these changes
May 30, 2025
metals/src/main/scala/scala/meta/internal/metals/mcp/MetalsMcpServer.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.