8000 feat(postman-to-openapi): import post-response scripts by hanspagel · Pull Request #5300 · scalar/scalar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(postman-to-openapi): import post-response scripts #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 7, 2025
Merged

feat(postman-to-openapi): import post-response scripts #5300

merged 13 commits into from
Apr 7, 2025

Conversation

hanspagel
Copy link
Member
@hanspagel hanspagel commented Apr 2, 2025 •
edited
Loading

Problem

Currently, we just omit Postman scripts. But what if … we import them?

Preparation for #4968.

Solution

With this PR we’re importing those post-response scripts!

And I’ve noticed a few things that I wanted to change in the same PR:

  • / paths are omitted
  • /raw paths are handled differently
  • responses are just made up
  • the 'default' tag is just created as a fallback (not necessary to make something up, let’s keep the data clean)
  • all the tests were skipped, let’s actually run them 👀

Checklist

I’ve gone through the following:

  • I’ve added an explanation why this change is needed.
  • I’ve added a changeset (pnpm changeset).
  • I’ve added tests for the regression or new feature.
  • I’ve updated the documentation.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Apr 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9d696f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@scalar/postman-to-openapi Minor
@scalar/api-client Patch
@scalar/nuxt Patch
@scalar/api-client-react Patch
@scalar/api-reference-editor Patch
@scalar/api-reference Patch
@scalar/play-button Patch
scalar-app Patch
@scalar/aspnetcore Pat 8000 ch
@scalar/fastify-api-reference Patch
@scalar/api-reference-react Patch
@scalar/cli Patch
@scalar/docusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hanspagel hanspagel changed the title feat(postman-to-openapi)/clean postman import feat(postman-to-openapi): import post-response scripts Apr 2, 2025
@hanspagel hanspagel marked this pull request as draft April 2, 2025 11:31
@hanspagel hanspagel mentioned this pull request Apr 2, 2025
Draft
6 tasks
@relativeci RelativeCI
Copy link
relativeci bot commented Apr 2, 2025 •
edited
Loading

#9143 Bundle Size — 2.41MiB (0%).

ae9cc46(current) vs 3783345 main#9134(baseline)

Warning

Bundle contains 6 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#9143		      Baseline
#9134
No change  Initial JS 2.41MiB 2.41MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1483 1483
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 172 172
No change  Duplicate Packages 6 6
Bundle size by type  no changes
                 Current
#9143		      Baseline
#9134
No change  JS 2.41MiB 2.41MiB

Bundle analysis report Branch feat/clean-postman-import Project dashboard

Generated by RelativeCI Documentation Report issue

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 2, 2025 •
edited
Loading

Preview Examples

https://5748a2a2-9789-4a48-9971-b7e7b5def7cd--scalar-deploy-preview.netlify.app

@hanspagel hanspagel self-assigned this Apr 2, 2025
@hanspagel hanspagel force-pushed the feat/clean-postman-import branch from 3e5d5df to 16fb48b Compare April 2, 2025 15:14
@hanspagel hanspagel marked this pull request as ready for review April 4, 2025 12:29
@hanspagel hanspagel force-pushed the feat/clean-postman-import branch from ae9cc46 to 9d696f4 Compare April 4, 2025 12:29
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 4, 2025

Cloudflare Preview for the API Client

https://ccc84821.client-staging-7m0.pages.dev

@hanspagel hanspagel merged commit 018e8b2 into main Apr 7, 2025
31 checks passed
@hanspagel hanspagel deleted the feat/clean-postman-import branch April 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amritk amritk amritk approved these changes

@geoffgscott geoffgscott Awaiting requested review from geoffgscott geoffgscott is a code owner

Assignees

@hanspagel hanspagel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanspagel @amritk
0