8000 chore: rename @scalar/scripts to @scalar-internal/build-scripts by hanspagel · Pull Request #5571 · scalar/scalar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: rename @scalar/scripts to @scalar-internal/build-scripts #5571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

chore: rename @scalar/scripts to @scalar-internal/build-scripts #5571

merged 3 commits into from
May 7, 2025

Conversation

hanspagel
Copy link
Member

Problem

We just recently added a private package called @scalar/scripts, but there’s an actual @scalar/scripts coming soon.

Solution

To avoid conflicts, this PR renames the package to @scalar-internal/build-scripts.

Checklist

I’ve gone through the following:

  • I’ve added an explanation why this change is needed.
  • I’ve added a changeset (pnpm changeset).
  • I’ve added tests for the regression or new feature.
  • I’ve updated the documentation.

@hanspagel hanspagel self-assigned this May 5, 2025
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c4d2fd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hanspagel hanspagel force-pushed the chore/rename-scalar-scripts branch from d43fd0a to e8fee15 Compare May 5, 2025 10:27
@relativeci RelativeCI
Copy link
relativeci bot commented May 5, 2025 •
edited
Loading

#9690 Bundle Size — 2.44MiB (0%).

c4d2fd8(current) vs f2bee61 main#9687(baseline)

Warning

Bundle contains 6 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#9690		      Baseline
#9687
No change  Initial JS 2.44MiB 2.44MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1492 1492
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 172 172
No change  Duplicate Packages 6 6
Bundle size by type  no changes
                 Current
#9690		      Baseline
#9687
No change  JS 2.44MiB 2.44MiB

Bundle analysis report Branch chore/rename-scalar-scripts Project dashboard

Generated by RelativeCI Documentation Report issue

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 5, 2025 •
edited
Loading

Preview Examples

https://cb92db2c-c1a2-43dc-bff0-3f44619742dd--scalar-deploy-preview.netlify.app

@hanspagel hanspagel force-pushed the chore/rename-scalar-scripts branch from e8fee15 to 0f79ae4 Compare May 6, 2025 13:31
@hanspagel hanspagel force-pushed the chore/rename-scalar-scripts branch from 0f79ae4 to c4d2fd8 Compare May 6, 2025 13:52
marclave
marclave approved these changes May 6, 2025
View reviewed changes
Copy link
Member
@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@hanspagel hanspagel merged commit 7d4c5dd into main May 7, 2025
33 checks passed
@hanspagel hanspagel deleted the chore/rename-scalar-scripts branch May 7, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclave marclave marclave approved these changes

@amritk amritk Awaiting requested review from amritk amritk is a code owner

@geoffgscott geoffgscott Awaiting requested review from geoffgscott geoffgscott is a code owner

Assignees

@hanspagel hanspagel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanspagel @marclave
0