8000 chore: require Node 20 (or above) by hanspagel · Pull Request #5656 · scalar/scalar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: require Node 20 (or above) #5656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2025
Merged

chore: require Node 20 (or above) #5656

merged 5 commits into from
May 16, 2025

Conversation

hanspagel
Copy link
Member

Problem

Currently, we require Node 18 or above for all our packages, but Node dropped support for Node 18 and we removed it from CI already.

Solution

Let’s just require Node 20 (or above).

I made it a minor release for all packages.

Taken from #5620, because that was failing for a strange reason.

Checklist

I’ve gone through the following:

  • [ x I’ve added an explanation why this change is needed.
  • I’ve added a changeset (pnpm changeset).
  • I’ve added tests for the regression or new feature.
  • I’ve updated the documentation.

@hanspagel hanspagel self-assigned this May 15, 2025
@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 37f7e75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@scalar/api-reference-react Minor
@scalar/openapi-to-markdown Minor
@scalar/postman-to-openapi Minor
@scalar/api-client-react Minor
@scalar/aspnetcore Minor
@scalar/docusaurus Minor
@scalar/code-highlight Minor
@scalar/nextjs-openapi Minor
@scalar/openapi-parser Minor
@scalar/react-renderer Minor
@scalar/use-codemirror Minor
@scalar/api-reference Minor
@scalar/build-tooling Minor
@scalar/openapi-types Minor
@scalar/ts-to-openapi Minor
@scalar/object-utils Minor
@scalar/express-api-reference Minor
@scalar/fastify-api-reference Minor
@scalar/mock-server Minor
@scalar/use-tooltip Minor
@scalar/void-server Minor
@scalar/nestjs-api-reference Minor
@scalar/nextjs-api-reference Minor
@scalar/api-client Minor
@scalar/components Minor
@scalar/use-toasts Minor
@scalar/draggable Minor
@scalar/oas-utils Minor
@scalar/use-hooks Minor
@scalar/hono-api-reference Minor
@scalar/nuxt Minor
@scalar/snippetz Minor
@scalar/config Minor
@scalar/galaxy Minor
@scalar/import Minor
@scalar/themes Minor
@scalar/icons Minor
@scalar/types Minor
@scalar/core Minor
scalar-app Patch
@scalar/sveltekit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a mainta 8000 iner who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
Inspect the changes and commit the updated snapshots if they are satisfactory.
If a snapshot-diff.png is not provided, the snapshots are different sizes.

@relativeci RelativeCI
Copy link
relativeci bot commented May 15, 2025 •
edited
Loading

#9837 Bundle Size — 2.45MiB (0%).

37f7e75(current) vs 1d1470c main#9833(baseline)

Warning

Bundle contains 6 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#9837		      Baseline
#9833
No change  Initial JS 2.45MiB 2.45MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1487 1487
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 172 172
No change  Duplicate Packages 6 6
Bundle size by type  no changes
                 Current
#9837		      Baseline
#9833
No change  JS 2.45MiB 2.45MiB

Bundle analysis report Branch chore/require-node-20 Project dashboard

Generated by RelativeCI Documentation Report issue

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 15, 2025 •
edited
Loading

Cloudflare Preview for the API Client

https://f859932b.client-staging-7m0.pages.dev

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 15, 2025 •
edited
Loading

Preview Storybook

https://f0e11cfe-40bf-48d9-8866-3977c94a6e48--scalar-components.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
Inspect the changes and commit the updated snapshots if they are satisfactory.
If a snapshot-diff.png is not provided, the snapshots are different sizes.

@hanspagel hanspagel marked this pull request as ready for review May 16, 2025 09:21
@hanspagel hanspagel force-pushed the chore/require-node-20 branch from 4149fbe to 37f7e75 Compare May 16, 2025 09:21
@hanspagel hanspagel merged commit 483ca93 into main May 16, 2025
34 checks passed
@hanspagel hanspagel deleted the chore/require-node-20 branch May 16, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amritk amritk Awaiting requested review from amritk amritk is a code owner

@geoffgscott geoffgscott Awaiting requested review from geoffgscott geoffgscott is a code owner

@hwkr hwkr Awaiting requested review from hwkr hwkr is a code owner

@marclave marclave Awaiting requested review from marclave marclave is a code owner

@xC0dex xC0dex Awaiting requested review from xC0dex xC0dex is a code owner

@cameronrohani cameronrohani Awaiting requested review from cameronrohani cameronrohani is a code owner

Assignees

@hanspagel hanspagel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanspagel @amritk
0