8000 Fix batch delete param by dora-korpar · Pull Request #868 · scality/cloudserver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix batch delete param #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2017
Merged

Fix batch delete param #868

merged 1 commit into from
Aug 16, 2017

Conversation

dora-korpar
Copy link
Contributor

batchDelete expects the first param to be an array, but was being passed an object, which caused misleading orphan keys to not be deleted if the completedHash did not match.

Addresses JIRA S3C-709

@dora-korpar
Copy link
Contributor Author

@ironman-machine try

@ironman-machine
Copy link
Contributor

Hello @dora-korpar

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/14422' with the following env. args:

{
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/6.4",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "rel/6.4",
    "SCALITY_S3_BRANCH": "FIX/S3C-709-BadDigest-error"
}

LaurenSpiegel
LaurenSpiegel previously approved these changes Aug 16, 2017
View reviewed changes
electrachong
electrachong previously approved these changes Aug 16, 2017
View reviewed changes
@ironman-machine
Copy link
Contributor

☀️ 👍 circleCI test succeeded!

@dora-korpar dora-korpar force-pushed the FIX/S3C-709-BadDigest-error branch from 3734d79 to e254b30 Compare August 16, 2017 18:40
@ironman-machine ironman-machine dismissed stale reviews from LaurenSpiegel, electrachong, and jonathan-gramain August 16, 2017 18:40

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@dora-korpar
Copy link
8000
Contributor Author

@ironman-machine go

@ironman-machine
Copy link
Contributor

Hello @dora-korpar

"go": Failure: Unknown command

@dora-korpar
Copy link
Contributor Author

@ironman-machine try

@ironman-machine
Copy link
Contributor

Hello @dora-korpar

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/14426' with the following env. args:

{
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/6.4",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "rel/6.4",
    "SCALITY_S3_BRANCH": "FIX/S3C-709-BadDigest-error"
}

@ironman-machine
Copy link
Contributor

💔 ☔ circleCI test failed.

@dora-korpar dora-korpar force-pushed the FIX/S3C-709-BadDigest-error branch from e254b30 to 8dc4231 Compare August 16, 2017 21:31
@dora-korpar
Copy link
Contributor Author

@ironman-machine try

@ironman-machine
Copy link
Contributor

Hello @dora-korpar

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/14430' with the following env. args:

{
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/6.4",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "rel/6.4",
    "SCALITY_S3_BRANCH": "FIX/S3C-709-BadDigest-error"
}

@dora-korpar dora-korpar merged commit b1f6cd9 into rel/6.4 Aug 16, 2017
@dora-korpar dora-korpar deleted the FIX/S3C-709-BadDigest-error branch August 16, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulreddy rahulreddy rahulreddy approved these changes

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

@LaurenSpiegel LaurenSpiegel LaurenSpiegel approved these changes

@electrachong electrachong electrachong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dora-korpar @ironman-machine @rahulreddy @jonathan-gramain @LaurenSpiegel @electrachong
0