8000 DateTime in jsonldcontext by madbob · Pull Request #4384 · schemaorg/schemaorg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DateTime in jsonldcontext #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DateTime in jsonldcontext #4384

wants to merge 2 commits into from

Conversation

madbob
Copy link
@madbob madbob commented Mar 30, 2025

File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.

@madbob
DateTime in jsonldcontext
34d9fc4 
File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.
gmackenz
gmackenz approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor
@gmackenz gmackenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

@gmackenz
Copy link
Contributor

Fails in the build test.

@madbob
Copy link
Author
madbob commented Apr 24, 2025

Seems that the test itself was broken: documentation says that dateModified may be both Date or DateTime, while software/tests/test_basics.py just tested for Date and failed with the "fixed" version of jsonldcontext.jsonld.

@gmackenz
Copy link
Contributor

tests now breaks for auditDate

gmackenz
gmackenz requested changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@gmackenz gmackenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test has another breakage for "auditDate"

@madbob
Copy link
Author
madbob commented Apr 25, 2025

Ok, I totally failed to properly check my pull request... Sorry...

But now, I'm a bit confused.

JSON-LD specification says something about expressing a type "with an IRI", as "a term defined in the active context", or "using an array", but omits details about the contents of the array (the only available example contains IRIs, it do not mentions terms).

On the other hand, given my limited understanding of Ruby, seems that json-ld gem only accepts a single string, in form of URI, assigned to type. Arrays seems not to be handled at all, with any content.

I've tried replacing Date and DateTime with schema:Date or fully qualified URLs as http://schema.org/Date, with no success in the validation by the json-ld gem. Probably I'm missing something, but don't know what...

@gmackenz
Copy link
Contributor

Not sure what value the test_basics for "Date" has and if we should keep it.

@gmackenz
Copy link
Contributor

Anyone else have some background on test or what should be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmackenz gmackenz gmackenz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madbob @gmackenz
0