build(pnpm): changing package manager to pnpm #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chestercheng
approved these changes
Apr 19, 2025
There was a problem hiding this comment.
Seems pnpm doesn't save the build time. It still took around 4 minutes with Netlify.
I'm not sure if it's because this is the first build, so it's without cache.
Ref: https://app.netlify.com/sites/swportal/deploys/680356f4d0758b0008a2ad60
Anyway, LGTM
jack482653
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last month I have a discussion with @jack482653, I proposed that pnpm is more convenient compared to yarn (e.g., package cache to reduce node_modules disk space). So I created this PR to change the behavior.