Closes #5 by embedding default files from the filesystem into the com… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR closes #5 by embedding default configuration and metrics files into the compiled binary, replacing inline string literals for default file creation. Key changes include:
- Adding new YAML files under defaults/data/metrics and defaults/config.
- Replacing file creation logic in config.go with a helper that copies embedded defaults.
- Organizing default levers and metrics configuration via embedded FS.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| defaults/data/metrics/infra_sec.yaml | Adds default infrastructure security metrics data. |
| defaults/data/metrics/compliance.yaml | Adds default compliance metrics data. |
| defaults/data/metrics/app_sec.yaml | Adds default application security metrics data. |
| defaults/config/metrics.yaml | Introduces metrics configuration with KPI and KRI scoring bands. |
| defaults/config/levers.yaml | Introduces lever thresholds and weights configuration. |
| config.go | Refactors default file creation to use the embedded file system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…piled binary