Restructure download handler tests. #6821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #6821 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 164 164
Lines 12381 12381
Branches 1609 1609
=======================================
Hits 11240 11240
Misses 834 834
Partials 307 307 |
Gallaecio
reviewed
May 27, 2025
fanisorfan
pushed a commit
to fanisorfan/scrapy
that referenced
this pull request
Jun 3, 2025
* Restructure download handler tests. * Typo. * Use mixins to reduce boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to reshuffle the test code to allow running the code with alternative download handlers. New structure:
DownloadHandlersand for specific non-HTTP download handlersAll the actually run test methods should be the same, except for 2 new but skipped methods in
test_downloader_handler_twisted_http10.TestHttp10Proxy. The 1.1 and 2 files are now independent from each other, only depending on the base file, though some 2 classes inherit from 1.1 ones, which I don't think we can do anything about as the protocols do the same. We may need some more restructuring when we actually get alternative handlers, especially ones with 2.0, but this is a first step.