8000 fix: Improve error handling in the getPrInfo method of scm-github by ibu1224 · Pull Request #246 · screwdriver-cd/scm-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Improve error handling in the getPrInfo method of scm-github #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ibu1224
Copy link
Contributor
@ibu1224 ibu1224 commented Jun 17, 2025

Context

Related PR is below.
screwdriver-cd/screwdriver#3353

This PR improves error handling in the getPrInfo method of scm-github.

Objective

  • Errors thrown by lookupScmUri won’t be caught because the call is outside the try...catch block.
    • Therefore, we will modify the code to call lookupScmUri inside a try-catch block.

References

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@ibu1224 ibu1224 marked this pull request as ready for review June 18, 2025 00:01
@minghay minghay merged commit 2159845 into screwdriver-cd:master Jun 18, 2025
1 check passed
@sd-buildbot
Copy link

🎉 This PR is included in version 14.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ibu1224 ibu1224 deleted the fix-error-handling branch June 18, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0