8000 AboutScreen unit test by catreedle · Pull Request #420 · scribe-org/Scribe-Android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AboutScreen unit test #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

AboutScreen unit test #420

wants to merge 4 commits into from

Conversation

catreedle
Copy link
Collaborator

Contributor checklist

Description

This PR adds new file /src/test/kotlin/be/scri/ui/screens/about/AboutUtilTest.kt to test the functionality of AboutScreen also refactor the code in ShareHelper.kt and AboutUtil.kt

Related issue

@github-actions GitHub Actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions GitHub Actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks so much for the PR here, @catreedle! We'll try to get to the review in the coming days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtavis andrewtavis Awaiting requested review from andrewtavis

@angrezichatterbox angrezichatterbox Awaiting requested review from angrezichatterbox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catreedle @andrewtavis
0