8000 Light client input validation (IBC Hooks + IBC contracts) by assafmo · Pull Request #1441 · scrtlabs/SecretNetwork · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Light client input validation (IBC Hooks + IBC contracts) #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
Jun 5, 2023
Merged

Light client input validation (IBC Hooks + IBC contracts) #1441

merged 58 commits into from
Jun 5, 2023

Conversation

assafmo
Copy link
Contributor
@assafmo assafmo commented May 16, 2023 •
edited
Loading

This PR adds light client input validation for the following use cases:

  • MsgRecvPacket to IBC-enabled contracts
  • MsgAcknowledge to IBC-enabled contracts
  • MsgTimeout to IBC-enabled contracts
  • ibc-hooks incoming transfer
  • ibc-hooks outgoing transfer ack
  • ibc-hooks outgoing transfer timeout

assafmo added 16 commits May 22, 2023 15:06
@assafmo assafmo marked this pull request as ready for review May 23, 2023 22:06
Cashmaney
Cashmaney requested changes May 29, 2023
View reviewed changes
@assafmo assafmo requested a review from Cashmaney May 31, 2023 06:13
@assafmo assafmo changed the title More light client input validation Light client input validation (IBC Hooks + IBC contracts) Jun 5, 2023
Base automatically changed from ibc-hooks to master June 5, 2023 09:40
@assafmo assafmo merged commit 9825f57 into master Jun 5, 2023
@assafmo assafmo deleted the ibc-input-light-client-validation branch June 5, 2023 09:41
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2023
View reviewed changes
x/registration/internal/types/types.go
@@ -13,7 +13,7 @@
MasterNodeKeyId = "NodeExchMasterKey"
MasterIoKeyId = "IoExchMasterKey"
SecretNodeSeedLegacyConfig = "seed.json"
SecretNodeSeedNewConfig = "new_seed.json"
SecretNodeSeedNewConfig = "new_seed.json" //nolint:gosec

Check failure

Code scanning / CodeQL

Hard-coded credentials

Hard-coded [secret](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toml01 toml01 Awaiting requested review from toml01 toml01 is a code owner

@liorbond liorbond Awaiting requested review from liorbond liorbond is a code owner

@Cashmaney Cashmaney Awaiting requested review from Cashmaney Cashmaney is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assafmo @Cashmaney
0