8000 SNIP-52: Add `env.transaction.hash` by assafmo · Pull Request #1498 · scrtlabs/SecretNetwork · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SNIP-52: Add env.transaction.hash #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 9, 2023
Merged

SNIP-52: Add env.transaction.hash #1498

merged 8 commits into from
Aug 9, 2023

Conversation

assafmo
Copy link
Contributor
@assafmo assafmo commented Aug 3, 2023 •
edited
Loading

assafmo added 2 commits August 4, 2023 01:21
@assafmo
Test env.transaction.hash
af0fbb4
@assafmo
Fix TestAllocateOnHeapFailBecauseMemoryLimitDuringMigrate for Rust > …
06494da 
…v1.61

Not sure if Rust v1.61 exactly, but somewhere between v1.62 and v1.67 They added more memory optimizations which made our test contracts to not really allocate 13MiB.
@assafmo assafmo force-pushed the snip-52-add-txhash-to-env branch from 797f456 to 540c065 Compare August 6, 2023 08:50
@assafmo
Continue fixing tests for Rust > v1.61
a9b46a9 
Not sure if Rust v1.61 exactly, but somewhere between v1.62 and v1.67 they added stuff which optimized away some of our tests the perform memory/pointer manipulations.
@assafmo assafmo force-pushed the snip-52-add-txhash-to-env branch from 540c065 to a9b46a9 Compare August 6, 2023 17:21
toml01
toml01 reviewed Aug 9, 2023
View reviewed changes
toml01
toml01 previously approved these changes Aug 9, 2023
View reviewed changes
assafmo
assafmo commented Aug 9, 2023
View reviewed changes
@assafmo
Revert stop the compiler from complaining that sig_info is not used…
d0d7607 
… in `verify_input_params()` when the `light-client-validation` feature is off

See #1506
@assafmo assafmo force-pushed the snip-52-add-txhash-to-env branch from ce65519 to d0d7607 Compare August 9, 2023 10:19
@assafmo assafmo merged commit d2763cd into master Aug 9, 2023
@assafmo assafmo deleted the snip-52-add-txhash-to-env branch August 9, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toml01 toml01 toml01 left review comments

@Cashmaney Cashmaney Awaiting requested review from Cashmaney Cashmaney is a code owner

@liorbond liorbond Awaiting requested review from liorbond liorbond is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assafmo @toml01
0