(fix): new keep alive workflow #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grst
reviewed
May 5, 2025
| @@ -106,5 +106,11 @@ jobs: | |||
| permissions: | |||
| actions: write | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: gautamkrishnar/keepalive-workflow@v2 | |||
| - name: Re-enable workflow | |||
There was a problem hiding this comment.
I think you still need a checkout or hardcode the name of the yml file
There was a problem hiding this comment.
Could you explain why? I don't see anything that would necessitate it so I'd like to understand what I'm missing.
There was a problem hiding this comment.
the original action additionally has
case "${GITHUB_WORKFLOW_REF:?}" in
"${GITHUB_REPOSITORY:?}"/.github/workflows/*.y*ml@*) ;;
*) false ;;
esacwhich somehow globs for the yml files. Now that I look at it again, I'm not sure it's required.
In any case ${workflow} in the API call should be the name of the workflow yml file. But I'm not really sure what the expression ${GITHUB_WORKFLOW_REF%%@*} evaluates to.
flying-sheep
reviewed
May 5, 2025
grst
reviewed
May 5, 2025
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.