10000 Airdrop | contract by FloppyDisck · Pull Request #116 · securesecrets/shade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Airdrop | contract #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 20, 2021
Merged

Airdrop | contract #116

merged 8 commits into from
Oct 20, 2021

Conversation

FloppyDisck
Copy link
Contributor

Added a working airdrop contract, integration tests for it are also implemented

@FloppyDisck FloppyDisck added the airdrop Airdrop contract label Oct 10, 2021
Comment on lines 21 to 27
pub airdrop_snip20: Contract,
// The airdrop time limit
pub start_date: Option<u64>,
// Can be set to never end
pub end_date: Option<u64>,
// Secret network delegators snapshot
pub rewards: Vec<Reward>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move rewards and snip20 into a handle like

Airdrop {
    snip20,
    Vec<Reward>,
}

Then in the storage you could store a users list of assets?
Trying to think of how this contract can still be useful post-airdrop, I believe we are planning to airdrop other tokens in the future such as synthetics

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sounds good, wdym by users list of assets?

Copy link
Collaborator
@DrPresident DrPresident Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just if there are multiple overlapping airdrops of different denoms, so one user could query all their pending funds at once.
We could also do future airdrops through the staking contract rewards but that would limit who we can airdrop to to just SHD stakers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to keep each airdrop separate, so each new coin is a separate airdrop contract

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	makefile
#	packages/network_integration/tests/testnet_integration.rs
#	packages/network_tester/Cargo.lock
#	packages/shade_protocol/src/lib.rs
@FloppyDisck FloppyDisck merged commit 3656dc6 into dev Oct 20, 2021
@FloppyDisck FloppyDisck deleted the airdrop/contract branch October 20, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airdrop Airdrop contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0