8000 Snip20 staking math update by FloppyDisck · Pull Request #211 · securesecrets/shade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Snip20 staking math update #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2022
Merged

Snip20 staking math update #211

merged 2 commits into from
May 13, 2022

Conversation

FloppyDisck
Copy link
Contributor

Description

Moved away from the ethnum library for 256bit unsigned integers and started using the compatibility uint library. By moving into the cosmwasm 1.0 uint lib staking now has most of its math in checked functions.

Notable changes

  • Migration to the protocol uint library
  • More type safety
  • Shares storage is now natively Uint256

Next steps

  • Implement errors lib
  • Push for 100% math safety

Copy link
Collaborator
@DrPresident DrPresident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch the base branch to dev but other than that looks good

@FloppyDisck FloppyDisck changed the base branch from main to dev May 13, 2022 17:21
@FloppyDisck
Copy link
Contributor Author

Switch the base branch to dev but other than that looks good

I swear it was on dev, github is playing tricks on me lol

@FloppyDisck FloppyDisck merged commit 4a131c7 into dev May 13, 2022
@FloppyDisck FloppyDisck deleted the staking/math_update branch May 13, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0