8000 Update ec build sha cli image by simonbaird · Pull Request #175 · securesign/cosign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update ec build sha cli image #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

simonbaird
Copy link

Contains ec v0.2.3 built on git sha
c21271a0ee838b676e0cdd955d752cbc8630a347 in the
enterprise-contract/ec-cli repo.

Note that the previous image was specified using an image tag, not the image digest, so that's why the diff looks like it does.

@simonbaird
Copy link
Author
$ podman run --rm quay.io/redhat-user-workloads/rhtap-contract-tenant/ec-v02/cli-v02@sha256:5624cb2a696679f82f25ae95be40b138eda1bf071b6fcd9177b7cd2da4ae7aa5 version | grep -E 'Version|Source|Change'
Version            v0.2.3
Source ID          c21271a0ee838b676e0cdd955d752cbc8630a347
Change date        2024-03-29 16:48:07 +0000 UTC (49 minutes ago)

@simonbaird
Copy link
Author
simonbaird commented Mar 29, 2024

I'm aware that the the final TAS builds might be done already. It would be nice if we can get this newer ec into the TAS release, but it's not super urgent.

Edit: IIUC the final build is next week now, so I expect there is time enough to include this.

Contains ec v0.2.3 built on git sha
c21271a0ee838b676e0cdd955d752cbc8630a347 in the
enterprise-contract/ec-cli repo.

Note that the previous image was specified using an image tag, not
the image digest, so that's why the diff looks like it does.
@simonbaird simonbaird force-pushed the update-ec-in-cli-image branch from 629920c to b87542b Compare March 29, 2024 17:47
@simonbaird
Copy link
Author

FYI @JasonPowr

@codecov-commenter
Copy link
codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@bcda53b). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage        ?   40.44%           
=======================================
  Files           ?      155           
  Lines           ?    10049           
  Branches        ?        0           
=======================================
  Hits            ?     4064           
  Misses          ?     5496           
  Partials        ?      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lance
Copy link
Member
lance commented Mar 29, 2024

/approve

I don't think this will work since we don't have an OWNERS file. But I don't understand why the Konflux build is not running.

@simonbaird
Copy link
Author
simonbaird commented Mar 29, 2024

I could probably fix the license check.

Edit: Actually I won't do that. It's not clear what license preamble belongs on those files, so I won't try to guess.

Edit again: I'm trying to fix the license check in another PR, #176 .

@JasonPowr
8000
Copy link

/retest

Copy link
@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonPowr, lance, simonbaird

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

733E @JasonPowr JasonPowr merged commit 9ba3a8a into securesign:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0