-
Notifications
You must be signed in to change notification settings - Fork 10
Update ec build sha cli image #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm aware that the the final TAS builds might be done already. It would be nice if we can get this newer ec into the TAS release, but it's not super urgent. Edit: IIUC the final build is next week now, so I expect there is time enough to include this. |
Contains ec v0.2.3 built on git sha c21271a0ee838b676e0cdd955d752cbc8630a347 in the enterprise-contract/ec-cli repo. Note that the previous image was specified using an image tag, not the image digest, so that's why the diff looks like it does.
629920c
to
b87542b
Compare
FYI @JasonPowr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage ? 40.44%
=======================================
Files ? 155
Lines ? 10049
Branches ? 0
=======================================
Hits ? 4064
Misses ? 5496
Partials ? 489 ☔ View full report in Codecov by Sentry. |
/approve I don't think this will work since we don't have an OWNERS file. But I don't understand why the Konflux build is not running. |
I could probably fix the license check. Edit: Actually I won't do that. It's not clear what license preamble belongs on those files, so I won't try to guess. Edit again: I'm trying to fix the license check in another PR, #176 . |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JasonPowr, lance, simonbaird The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contains ec v0.2.3 built on git sha
c21271a0ee838b676e0cdd955d752cbc8630a347 in the
enterprise-contract/ec-cli repo.
Note that the previous image was specified using an image tag, not the image digest, so that's why the diff looks like it does.