8000 Add MySQL TLS support by fghanmi · Pull Request #261 · securesign/trillian · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add MySQL TLS support #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Add MySQL TLS support #261

merged 1 commit into from
Aug 17, 2024

Conversation

fghanmi
Copy link
@fghanmi fghanmi commented Aug 17, 2024

This PR adds TLS support for MySQL connections in the Trillian server/signer. The key changes include:

  • Added new flags:

    • mysql_tls_ca: Path to the CA certificate file for the MySQL TLS connection.
    • mysql_server_name: Name of the MySQL server to be used as the Server Name in the TLS configuration.
  • TLS Configuration Registration:

    • Added a new function registerTLSConfig() to handle the registration of the custom TLS configuration.

If no TLS configuration is provided, the connection defaults to non-TLS, ensuring backward compatibility.

Issue: google#3592

Checklist

Adds TLS support for MySQL connections in the Trillian server/signer.

Key changes include:
- Added new flags:
  + mysql_tls_ca: Path to the CA certificate file for the MySQL TLS connection.
  + mysql_server_name: Name of the MySQL server to be used as the Server Name in the TLS configuration.
- Added a new function registerTLSConfig() to handle the registration of the custom TLS configuration.

If no TLS configuration is provided, the connection defaults to non-TLS, ensuring backward compatibility.

Issue: google#3592
Copy link
openshift-ci bot commented Aug 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fghanmi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fghanmi fghanmi merged commit abffea1 into main Aug 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0