8000 Fix missing PrivacyInfo.xcprivacy in xcodeproj file by Adobels · Pull Request #119 · securing/IOSSecuritySuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing PrivacyInfo.xcprivacy in xcodeproj file #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

Adobels
Copy link
Contributor
@Adobels Adobels commented Apr 11, 2024

Summary of Changes

This PR addresses an issue in the framework building process by ensuring PrivacyInfo.xcprivacy is included in the resulting artifact. This fixes an oversight in PR 114

Changes Made

  1. Resolved issue where PrivacyInfo.xcprivacy was missing when integrated via Xcode Package Dependencies.
  • Updated swift-tools to 5.3 to support a target resources declaration
  • Updated the definition of the IOSSecuritySuite target to include the resources argument with '.copy(PrivacyInfo.xcprivacy)
  • Moved the Resources directory to be part of the target folder. Its previous location was not accessible by the target resource declaration.
  1. Fix PrivacyInfo.xcprivacy is missing when build with xcodebuild
  • Only the xcodeproj file was changed. This update ensures that PrivacyInfo.xcprivacy is included when the framework is built using xcodebuild.

Tests

Tests were made manually, involving the integration of the framework through Xcode Package Dependencies and building the xcframework using xcodebuild. In both scenarios, PrivacyInfo.xcprivacy was successfully included within the framework.

Adobels added 4 commits April 11, 2024 15:08
…w resources defintion in targets

Fix missing PrivacyInfo.xcprivacy when building framework using Xcode Package Dependencies.
…side target folder

Fix missing PrivacyInfo.xcprivacy when building framework using Xcode Package Dependencies.
- Resources folder must be part of a target folder hierarchy
Fix missing PrivacyInfo.xcprivacy when building framework using Xcode Package Dependencies.
@r3ggi
Copy link
Collaborator
r3ggi commented Apr 12, 2024

thx for the fix!

@r3ggi r3ggi merged commit 02d981c into securing:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0