8000 support merge flags when use clusterfile for run and apply by kakaZhou719 · Pull Request #1955 · sealerio/sealer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support merge flags when use clusterfile for run and apply #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

support merge flags when use clusterfile for run and apply #1955

merged 1 commit into from
Jan 5, 2023

Conversation

kakaZhou719
Copy link
Member

Describe what this PR does / why we need it

  1. support merge flags when use clusterfile for run and apply
  2. bugfix: no need to specify master ip when run app image
  3. optimize: each cmd use their own flags

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added the test label Jan 5, 2023
@kakaZhou719 kakaZhou719 force-pushed the support-add-flags-when-use-clusterfile branch 2 times, most recently from c4b2b7e to 985fd74 Compare January 5, 2023 10:39
support merge flags when use clusterfile for run and apply
6390013 
support merge flags when use clusterfile for run and apply
@kakaZhou719 kakaZhou719 force-pushed the support-add-flags-when-use-clusterfile branch from 985fd74 to 6390013 Compare January 5, 2023 10:40
VinceCui
VinceCui reviewed Jan 5, 2023
View reviewed changes
Copy link
Collaborator
@VinceCui VinceCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinceCui VinceCui merged commit b55f5b5 into sealerio:main Jan 5, 2023
@kakaZhou719 kakaZhou719 deleted the support-add-flags-when-use-clusterfile branch March 8, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceCui VinceCui VinceCui approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakaZhou719 @VinceCui
0