Change content-type from json to x-ndjson (sent by searchkit to the search engine API) #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searchkit was sending "application/json" to the search engine API, this is technically incorrect, since the body of the request is a list of jsons concatenated by newline. This breaks the parsing of the request body on some (proxy) servers, for example Ruby on Rails, since when it tries to parse a json, if finds it is broken. This fixes searchkit#1360.
|
thanks for submitting the PR, sorry haven't got back to this. Will review tomorrow. |
joemcelroy
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searchkit was sending "application/json" to the search engine API, this is technically incorrect, since the body of the request is a list of jsons concatenated by newline. This breaks the parsing of the request body on some (proxy) servers, for example Ruby on Rails, since when it tries to parse a json, if finds it is broken.
This fixes #1360.