fix: client default scope cleanup #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug during the deletion of a custom scope.
When you had a custom scope assigned to a client, but only added it to the
default_scopeswithout allowing it forscopesin general, this mapping would get lost during the cleanup of the client mapping, when the custom scope has been deleted without removing the mapping first.If this happened, you had to remove the scope mapping from the client manually to fix it.
This was due to a check if the to-be-deleted scope exists at all for this client and exit early if not. However, it is possible that a scope exists in default scopes only, so that the client does not have a choice and it will always be added. This has been fixed and an extra test case for this special case has been added as well.