8000 fix(getPlaylist): populate ArtistID and AlbumID by richardsamuels · Pull Request #567 · sentriz/gonic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(getPlaylist): populate ArtistID and AlbumID #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(getPlaylist): populate ArtistID and AlbumID #567

wants to merge 7 commits into from

Conversation

richardsamuels
Copy link

The OpenSubsonic getPlaylist spec doc lists artistId and albumId as fields for playlist entries, which are currently not being populated.

This PR populates those fields.

@richardsamuels
Copy link
Author

Tests fixed.

  • The changes to .golangci.yml are to fix this error that popped up. It appears to be caused by an update to your linter action.
  • The testdata files were not formatted in a readable way after using GONIC_REGEN, so I ran them through jq. This did not match your previous formatting perfectly. Let me know if you have a preferred linter for those files and I can fix them.

@sentriz
Copy link
Owner
sentriz commented Mar 24, 2025

thanks @richardsamuels would you mind rebasing? i also usually format with prettier --parser json --write server/ctrlsubsonic/testdata/*

sentriz
sentriz reviewed Mar 24, 2025
View reviewed changes
server/ctrlsubsonic/spec/construct_by_folder.go
@@ -101,6 +102,9 @@ func NewTCTrackByFolder(t *db.Track, parent *db.Album) *TrackChild {
trCh.Genres = append(trCh.Genres, &GenreRef{Name: g.Name})
}
for _, a := range t.Artists {
if a.Name == t.TagTrackArtist {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this check for?

9A5E

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each TrackChild has a single ArtistID, which corresponds to the TagTrackArtist. The check just makes sure that we assign the correct ArtistID to to the TrackChild. If this check wasn't here, it would assign the track's ArtistID to the last artist in the Artists list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentriz sentriz sentriz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardsamuels @sentriz
0