This repository was archived by the owner on Jun 8, 2020. It is now read-only.
Depend on servo-fontconfig-sys properly #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fbc247 to
b2cb245
Compare
|
@bors-servo r+ |
|
📌 Commit b2cb245 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 10, 2016
Run cargo test with VERBOSE=1 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/107) <!-- Reviewable:end -->
|
@bors-servo r=Manishearth,jack |
|
📌 Commit fee730a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 10, 2016
Depend on servo-fontconfig-sys properly <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/107) <!-- Reviewable:end -->
|
I think you want to bump the version to 16, because the current one is 15. |
|
Ah... |
|
@bors-servo r=Manishearth,jack |
|
📌 Commit f5fe2ac has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 10, 2016
Depend on servo-fontconfig-sys properly <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/107) <!-- Reviewable:end -->
|
By the power of larsbors, I'll merge this by hand. Cc @larsbergstrom. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is