Tags: shoeb751/osv
Tags
VFS: fix expansion of symbolic links inside mounts We had a bug processing symbolic links in a filesystem not mounted on /. Since recently, scripts/build runs cpiod.so while the ZFS filesystem is mounted on "/zfs/zfs", not "/", so this bug was exposed, and made "build image=java-tests,openjdk8-fedora", for example, fail, while trying to use a symbolic link which seemed to be set up correctly. The problem was in the namei() function, which among other things expands symbolic links while translating 8000 a pathname into a vnode. Internally, namei() separates a full path like /zfs/zfs/usr/lib/jvm/java into a mount point (/zfs/zfs) and node (/usr/lib/jvm/java), and looks up only the node inside the file system. However, the *target* of the symbolic link is in the context of the whole system, not necessarily inside this mountpoint. The code forgot that the full path contains the mountpoint (/zfs/zfs) which node does not, and when the mountpoint wasn't "/", it messed up some calculations, and the result was botched up symbolic link translations, and using the symbolic links inside a path failed. Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by: Pekka Enberg <penberg@scylladb.com>
README: fix outdated information The information in README.md about the "img_format" make parameter is outdated. The current build script always builds a qcow2 image, and it can be converted by the scripts/convert script. Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
update gitignore Update .gitignore to ignore various files that some of the modules in modules/ (i.e., the OSv core repository and not osv-apps) seem to build outside the build/ directory. Also ignore the build.out file (a new file where scripts/build saves the output of the last "make"). After this patch, "git status" is empty even after building images. Fixes cloudius-systems#610. Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
Add line breaks to CODINGSTYLE Before this commit, viewing CODINGSTYLE.md in a Markdown renderer (such as the GitHub website) would result in some paragraphs (like 5.1 and 5.2) being visually on the same line. This patch adds trivial newlines between them in the hope of improving readability. Reviewed-by: Nadav Har'El <nyh@cloudius-systems.com> Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>
Revert "scripts: Make release images include default configuration" This reverts commit 1fa7491. We don't want to automatically pull the CLI, for example, for Redis appliances. Switch back to requiring release images to explicitly specify their dependencies. Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>
PreviousNext