10000 Separate local minio and remote s3 for image&video by Leslie-Wong-H · Pull Request #105 · shotit/shotit-media · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Separate local minio and remote s3 for image&video #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Conversation

Leslie-Wong-H
Copy link
Member

Local Minio, directly mp4 files

Remote S3, fetch hls files to reduce network IO

@codecov
Copy link
codecov bot commented Jun 3, 2023

Codecov Report

Merging #105 (40f179f) into main (50759ce) will decrease coverage by 0.33%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   71.39%   71.06%   -0.33%     
==========================================
  Files          12       12              
  Lines         423      432       +9     
  Branches       82       88       +6     
==========================================
+ Hits          302      307       +5     
- Misses        115      119       +4     
  Partials        6        6              
Flag Coverage Δ
unittests 71.06% <90.90%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/image.js 86.84% <50.00%> (-2.05%) ⬇️
src/video.js 88.63% <50.00%> (-1.84%) ⬇️
src/lib/generate-video-preview.js 94.44% <95.00%> (-3.52%) ⬇️

@Leslie-Wong-H Leslie-Wong-H changed the title Seperate local minio and remote s3 for image&video Separate local minio and remote s3 for image&video Jun 3, 2023
@Leslie-Wong-H Leslie-Wong-H merged commit 8a3f7f6 into main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0