8000 Fix: the mp4 path is not mandatory when remote S3 by Leslie-Wong-H · Pull Request #165 · shotit/shotit-media · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: the mp4 path is not mandatory when remote S3 #165

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Fix: the mp4 path is not mandatory when remote S3 #165

merged 3 commits into from
Jul 21, 2023

Conversation

Leslie-Wong-H
Copy link
Member

No description provided.

@codecov
Copy link
codecov bot commented Jul 21, 2023

Codecov Report

Merging #165 (a544dad) into main (9850a7a) will increase coverage by 4.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   71.06%   75.17%   +4.10%     
==========================================
  Files          12       12              
  Lines         432      431       -1     
  Branches       88       88              
==========================================
+ Hits          307      324      +17     
+ Misses        119      102      -17     
+ Partials        6        5       -1     
Flag Coverage Δ
unittests 75.17% <100.00%> (+4.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/image.js 86.84% <ø> (ø)
src/lib/detect-scene.js 88.13% <ø> (ø)
src/lib/generate-video-preview.js 94.44% <ø> (ø)
src/lib/get-video-duration.js 80.64% <ø> (+58.06%) ⬆️
src/video.js 88.37% <100.00%> (-0.27%) ⬇️

@Leslie-Wong-H Leslie-Wong-H changed the title Dev Fix: the mp4 path is not mandatory when remote S3 Jul 21, 2023
@Leslie-Wong-H Leslie-Wong-H added the bug Something isn't working label Jul 21, 2023
@Leslie-Wong-H Leslie-Wong-H merged commit 592976c into main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0