8000 Fix reciprocal polynomial test bug by sritchie · Pull Request #481 · sicmutils/sicmutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jun 18, 2025. It is now read-only.

Fix reciprocal polynomial test bug #481

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Fix reciprocal polynomial test bug #481

merged 3 commits into from
Feb 16, 2022

Conversation

sritchie
Copy link
Member

This PR:

  • fixes a long-standing (test-only) bug in sicmutils.polynomial-test around
    palindromic polynomials

  • Adds a new x-degree argument to sicmutils.polynomial/univariate->dense,
    for padding the result with zeros in the case that you want to guarantee a
    certain dense degree in the result.

@codecov-commenter
Copy link
codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #481 (a3b4c1e) into main (450334e) will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   86.38%   86.41%   +0.02%     
==========================================
  Files         100      100              
  Lines       14406    14410       +4     
  Branches      749      749              
==========================================
+ Hits        12445    12452       +7     
+ Misses       1212     1209       -3     
  Partials      749      749              
Impacted Files Coverage Δ
src/sicmutils/polynomial.cljc 83.17% <93.75%> (-0.37%) ⬇️
src/sicmutils/numsymb.cljc 92.90% <0.00%> (+0.44%) ⬆️
src/sicmutils/rational_function.cljc 81.46% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450334e...a3b4c1e. Read the comment docs.

@sritchie sritchie merged commit 65e3546 into main Feb 16, 2022
@sritchie sritchie deleted the sritchie/poly_bug branch February 16, 2022 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0