8000 Slim down imports, move examples => tests by sritchie · Pull Request #532 · sicmutils/sicmutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Slim down imports, move examples => 8000 tests #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 22, 2023
Merged

Slim down imports, move examples => tests #532

merged 6 commits into from
Jan 22, 2023

Conversation

sritchie
Copy link
Member
@sritchie sritchie commented Jan 21, 2023 •
edited
Loading

  • Slim down imports, move examples => tests #532:

    • Removes the potemkin dependency by importing only what we need directly
      into sicmutils.util.def. This makes sense since our versions add a fork
      call so that they work for ClojureScript as well.

    • Moves all examples into the tests so that we don't ship them with the
      library. These will eventually be converted to Clerk notebooks.

    • Removes the hiccup dependency.

    • Upgrades test.chuck and removes all :include-macros true calls for that
      library. Only same/ish requires them now!

    • Capitalizes the "Script" in ClojureScript everywhere it appears.

@codecov-commenter
Copy link
codecov-commenter commented Jan 22, 2023 •
edited
Loading

Codecov Report

Base: 86.61% // Head: 86.48% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (3cb99ef) compared to base (f427fd0).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   86.61%   86.48%   -0.13%     
==========================================
  Files         104       98       -6     
  Lines       15356    15246     -110     
  Branches      774      783       +9     
==========================================
- Hits        13301    13186     -115     
+ Misses       1281     1277       -4     
- Partials      774      783       +9
Impacted Files Coverage Δ
src/pattern/rule.cljc 96.95% <ø> (ø)
src/sicmutils/calculus/derivative.cljc 79.83% <ø> (ø)
src/sicmutils/complex.cljc 92.20% <ø> (ø)
src/sicmutils/env.cljc 93.33% <ø> (ø)
src/sicmutils/expression/compile.cljc 89.54% <ø> (ø)
src/sicmutils/numbers.cljc 86.48% <ø> (ø)
src/sicmutils/polynomial.cljc 83.43% <ø> (ø)
src/sicmutils/quaternion.cljc 88.71% <ø> (ø)
src/sicmutils/ratio.cljc 89.04% <ø> (ø)
src/sicmutils/value.cljc 83.08% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sritchie sritchie changed the title Remove Potemkin import Slim down imports, move examples => tests Jan 22, 2023
@sritchie sritchie merged commit f181f15 into main Jan 22, 2023
@sritchie sritchie deleted the sritchie/potemkin_replace branch January 22, 2023 06:48
littleredcomputer pushed a commit that referenced this pull request Jan 30, 2023
@sritchie @littleredcomputer
Slim down imports, move examples => tests (#532)
82f31b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sritchie @codecov-commenter
0